On Fri, Feb 20, 2009 at 02:54:43PM +0800, Yu Zhao wrote: > Signed-off-by: Yu Zhao <yu.zhao@xxxxxxxxx> It needs a changelog ... > +static void sriov_restore_state(struct pci_dev *dev) > +{ [...] > +} > + [...] > +/** > + * pci_restore_iov_state - restore the state of the IOV capability > + * @dev: the PCI device > + */ > +void pci_restore_iov_state(struct pci_dev *dev) > +{ > + if (dev->sriov) > + sriov_restore_state(dev); > +} Apart from the design pattern I mentioned in my previous email also appearing here, I see no problems with this patch. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html