On Mon, 2009-02-23 at 12:27 -0500, Matthew Wilcox wrote: > By changing from a 5-bit field to a 1-bit field, we free up some bits > that can be used by a later patch. Also rearrange the fields for better > packing on 64-bit platforms (reducing the size of msi_desc from 72 bytes > to 64 bytes). > > diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c > index dceea56..b3db438 100644 > --- a/drivers/pci/msi.c > +++ b/drivers/pci/msi.c > @@ -393,7 +355,7 @@ static int msi_capability_init(struct pci_dev *dev) > if (!entry) > return -ENOMEM; > > - entry->msi_attrib.type = PCI_CAP_ID_MSI; > + entry->msi_attrib.is_msix = 0; This isn't strictly necessary given we kzalloc'ed the entry, but no biggie. Looks good otherwise. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
Attachment:
signature.asc
Description: This is a digitally signed message part
