On Fri, 13 Feb 2009 13:15:10 -0800 Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote: > On Tuesday, February 3, 2009 3:43 pm akpm@xxxxxxxxxxxxxxxxxxxx wrote: > > The patch titled > > pci: constify pci_bus_assign_resources() > > has been added to the -mm tree. Its filename is > > pci-constify-pci_bus_assign_resources.patch > > > > Before you just go and hit "reply", please: > > a) Consider who else should be cc'ed > > b) Prefer to cc a suitable mailing list as well > > c) Ideally: find the original patch on the mailing list and do a > > reply-to-all to that, adding suitable additional cc's > > > > *** Remember to use Documentation/SubmitChecklist when testing your code > > *** > > > > See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find > > out what to do about this > > > > The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ > > > > ------------------------------------------------------ > > Subject: pci: constify pci_bus_assign_resources() > > From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > > > drivers/pci/hotplug/fakephp.c: In function 'pci_rescan_bus': > > drivers/pci/hotplug/fakephp.c:271: warning: passing argument 1 of > > 'pci_bus_assign_resources' discards qualifiers from pointer target type > > > > Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> > > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > Applied these constifications to my linux-next branch, thanks Andrew. Something seems to have gone wrong. pci-constify-pci_bus_assign_resources.patch also did this: --- a/drivers/pci/setup-bus.c~pci-constify-pci_bus_assign_resources +++ a/drivers/pci/setup-bus.c @@ -27,7 +27,7 @@ #include <linux/slab.h> -static void pbus_assign_resources_sorted(struct pci_bus *bus) +static void pbus_assign_resources_sorted(const struct pci_bus *bus) { struct pci_dev *dev; struct resource *res; but that hunk got lost and we now get drivers/pci/setup-bus.c: In function 'pci_bus_assign_resources': drivers/pci/setup-bus.c:503: warning: passing argument 1 of 'pbus_assign_resources_sorted' discards qualifiers from pointer target type -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
