Hi Andrew,
* akpm@xxxxxxxxxxxxxxxxxxxx <akpm@xxxxxxxxxxxxxxxxxxxx>:
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>
> drivers/pci/hotplug/fakephp.c:283: warning: passing argument 1
> of 'pci_bus_add_devices' discards qualifiers from pointer
> target type
Can we live with this warning for another cycle or two?
I was going to fix up fakephp to eliminate this warning, but then
decided, "what's the point" since I plan on replacing it
wholesale anyway.
Same comment applies to your 3/6 patch in this series too...
Thanks.
/ac
>
> Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
>
> drivers/pci/bus.c | 2 +-
> include/linux/pci.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff -puN drivers/pci/bus.c~pci-constify-pci_bus_add_devices drivers/pci/bus.c
> --- a/drivers/pci/bus.c~pci-constify-pci_bus_add_devices
> +++ a/drivers/pci/bus.c
> @@ -133,7 +133,7 @@ int pci_bus_add_child(struct pci_bus *bu
> *
> * Call hotplug for each new devices.
> */
> -void pci_bus_add_devices(struct pci_bus *bus)
> +void pci_bus_add_devices(const struct pci_bus *bus)
> {
> struct pci_dev *dev;
> struct pci_bus *child;
> diff -puN include/linux/pci.h~pci-constify-pci_bus_add_devices include/linux/pci.h
> --- a/include/linux/pci.h~pci-constify-pci_bus_add_devices
> +++ a/include/linux/pci.h
> @@ -528,7 +528,7 @@ void pcibios_update_irq(struct pci_dev *
> /* Generic PCI functions used internally */
>
> extern struct pci_bus *pci_find_bus(int domain, int busnr);
> -void pci_bus_add_devices(struct pci_bus *bus);
> +void pci_bus_add_devices(const struct pci_bus *bus);
> struct pci_bus *pci_scan_bus_parented(struct device *parent, int bus,
> struct pci_ops *ops, void *sysdata);
> static inline struct pci_bus * __devinit pci_scan_bus(int bus, struct pci_ops *ops,
> _
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
