Re: [PATCH resend] PCI: check if a bus is added when removing it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, January 28, 2009 2:27 am Yu Zhao wrote:
> When removing a bus, 'is_added' should be checked to make sure the
> bus has been successfully added by pci_bus_add_child() who will sets
> 'is_added'.
>
> Signed-off-by: Yu Zhao <yu.zhao@xxxxxxxxx>
> ---
>  drivers/pci/remove.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
> index 042e089..caf8e1e 100644
> --- a/drivers/pci/remove.c
> +++ b/drivers/pci/remove.c
> @@ -71,6 +71,9 @@ void pci_remove_bus(struct pci_bus *pci_bus)
>  	down_write(&pci_bus_sem);
>  	list_del(&pci_bus->node);
>  	up_write(&pci_bus_sem);
> +	if (!pci_bus->is_added)
> +		return;
> +
>  	pci_remove_legacy_files(pci_bus);
>  	device_remove_file(&pci_bus->dev, &dev_attr_cpuaffinity);
>  	device_remove_file(&pci_bus->dev, &dev_attr_cpulistaffinity);

Applied, thanks Zhao.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux