Matthew Wilcox wrote: > On Mon, Feb 09, 2009 at 10:40:55AM +0900, Hidetoshi Seto wrote: >> The commit bffac3c593eba1f9da3efd0199e49ea6558a40ce ("PCI MSI: Fix >> undefined shift by 32") does: > > I think the commit message could be worded somewhat better, and I think > I should be credited as the author of the patch. How about this? > > ---- > > From: Matthew Wilcox <willy@xxxxxxxxxxxxxxx> > > Hidetoshi Seto points out that commit > bffac3c593eba1f9da3efd0199e49ea6558a40ce has wrong values in the > array. Rather than correct the array, we can just use a bounds check > and perform the calculation specified in the comment. As a bonus, this > will not run off the end of the array if the device specifies an illegal > value in the MSI capcbility. ^^^^^^^^^^ capability > > Signed-off-by: Matthew Wilcox <willy@xxxxxxxxxxxxxxx> > Signed-off-by: Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx> It looks good for me other than the typo above. Thanks, H.Seto -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html