On Wednesday 04 February 2009, Benjamin Herrenschmidt wrote: > On Wed, 2009-02-04 at 11:14 +0100, Frans Pop wrote: > > Benjamin Herrenschmidt wrote: > > > Minor nit: Should the warning be preceeded by a message ? The > > > reason is, right now, all we get is a backtrace, it doesn't > > > actually tell you which device or driver caused it which makes it > > > pretty pointless. > > > > > > I think you should add a printk(KERN_ERR... just before that which > > > gives those informations along with a little blurb along the lines > > > of "driver changed device state without saving config space > > > state"). > > > > That is actually already included in the patch (through > > drv->suspend): > > How so ? I've had such backtraces with no other info in my log... Previous versions did not have the info, but with this patch I get: WARNING: at drivers/pci/pci-driver.c:374 pci_legacy_suspend+0x9b/0xde() Hardware name: HP Compaq 2510p Notebook PC PCI PM: Device state not saved by iwl_pci_suspend+0x0/0x4c [iwlagn] [...] Driver and function causing the warning are in the last line. Cheers, FJP -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
