On Tue, 2009-02-03 at 18:23 -0800, Linus Torvalds wrote: > Whaa? This is basically totally obfuscated code both in the caller _and_ > in the callee. > > Now, it looks like this all then goes away in PATCH 7/7, so I guess I > shouldn't complain too much, but I just don't see much point in carrying > this broken patch around in the series, since it's then going away and > rewritten almost immediately again. > > Apart from that complaints, Acked-by: for the series. Same comments. It took me a while to figure the logic out, which I end up agreeing with but the code is pretty obfuscated ... And yes, patch 7 seems to improve things, but then, that makes reading the patch itself nearly impossible :-) I ended up patching the file and -then- reading it. I tried the whole thing on various powerbooks, along with some patches I'm about to send for radeonfb, atyfb and aty128fb to make them properly call pci_save_state() before they hand-change the D state, and things appear to be working fine. (well, appart from some unrelated problems leading to some might_sleep() hits but as I said, they are unrelated to this series) I need a couple more tests of the fbdev patches on some machine variants and once done, I'll post them out. Hopefully tonight. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
