Matthew Garrett wrote: > Some hardware exposes PCIE slots in such a way that they can be claimed by > either the acpiphp or pciehp driver. pciehp is the preferred driver if the > firmware allows the OS to claim control via the _OSC method so should be > loaded first - if it fails to bind (either due to a missing _OSC method or > the firmware refusing to hand off control) then we can fall back to acpiphp or > a vendor-specific driver. > > This patch simply changes the link order to ensure that pciehp will be > initialised before acpiphp if both are statically built into the kernel. > > Signed-off-by: Matthew Garrett <mjg@xxxxxxxxxx> Hi, I'd prefer to have a comment in the Makefile (not just in git) that link order is important for those 2 drivers and why. We do that in several other similar situations and I believe that having it in the Makefile is preferable. > --- > > diff --git a/drivers/pci/hotplug/Makefile b/drivers/pci/hotplug/Makefile > index e31fb91..a024b44 100644 > --- a/drivers/pci/hotplug/Makefile > +++ b/drivers/pci/hotplug/Makefile > @@ -5,11 +5,11 @@ > obj-$(CONFIG_HOTPLUG_PCI) += pci_hotplug.o > obj-$(CONFIG_HOTPLUG_PCI_COMPAQ) += cpqphp.o > obj-$(CONFIG_HOTPLUG_PCI_IBM) += ibmphp.o > +obj-$(CONFIG_HOTPLUG_PCI_PCIE) += pciehp.o > obj-$(CONFIG_HOTPLUG_PCI_ACPI) += acpiphp.o > obj-$(CONFIG_HOTPLUG_PCI_ACPI_IBM) += acpiphp_ibm.o > obj-$(CONFIG_HOTPLUG_PCI_CPCI_ZT5550) += cpcihp_zt5550.o > obj-$(CONFIG_HOTPLUG_PCI_CPCI_GENERIC) += cpcihp_generic.o > -obj-$(CONFIG_HOTPLUG_PCI_PCIE) += pciehp.o > obj-$(CONFIG_HOTPLUG_PCI_SHPC) += shpchp.o > obj-$(CONFIG_HOTPLUG_PCI_RPA) += rpaphp.o > obj-$(CONFIG_HOTPLUG_PCI_RPA_DLPAR) += rpadlpar_io.o > -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
