On Fri, 23 Jan 2009, Michael Ellerman wrote:
On Fri, 2009-01-23 at 15:24 +1100, Timothy S. Nelson wrote:
Hi all. I've inserted the patch I want to ask about below. It's
supposed to be an updated version of the patch that produces sensible errors
if people try to read a ROM incorrectly. The problem seems to be with the
line that says:
if(! res->flags & IORESOURCE_MEM) {
Which are you intending here, "not res->flags, and IORESOURCE_MEM", or
is it "not, res->flags and IORESOURCE_MEM" ?
if(! (res->flags & IORESOURCE_MEM)) {
I've put the parentheses in to clarify what I mean. But now that I
look at man perlop (perl keeps the same precedence as C), I can see I've done
it wrong. Thanks :).
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
---------------------------------------------------------------------
| Name: Tim Nelson | Because the Creator is, |
| E-mail: wayland@xxxxxxxxxxxxx | I am |
---------------------------------------------------------------------
----BEGIN GEEK CODE BLOCK----
Version 3.12
GCS d+++ s+: a- C++$ U+++$ P+++$ L+++ E- W+ N+ w--- V-
PE(+) Y+>++ PGP->+++ R(+) !tv b++ DI++++ D G+ e++>++++ h! y-
-----END GEEK CODE BLOCK-----
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
