Re: [PATCH] Fix MSI masking bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday, January 19, 2009 4:40 pm Matthew Wilcox wrote:
> Commit 5993760f7fc75b77e4701f1e56dc84c0d6cf18d5 replaced:
>
> -               pci_write_config_dword(dev,
> -                       msi_mask_bits_reg(pos, is_64bit_address(control)),
> -                       maskbits);
> +               pci_write_config_dword(dev, entry->msi_attrib.is_64,
> maskbits);
>
> which, instead of writing to an offset from the MSI capability, writes
> to the PCI vendor and device IDs.  Fortunately these are specified to
> be read-only, and we won't even do the write if the capability is 64-bit
> (due to the write being misaligned), but it would be nice to actually do
> the masking.

I think Hidetoshi's patch already fixed this, albeit slightly differently 
(0db29af1e767464d71b89410d61a1e5b668d0370 in my for-linus branch).


-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux