On Mon, Jan 19, 2009 at 12:07:04PM +1100, Michael Ellerman wrote: > Weak functions aren't all they're cracked up to be. They lead to > incorrect binaries with some toolchains, they require us to have empty > functions we otherwise wouldn't, and the unused code is not elided > (as of gcc 4.3.2 anyway). I'm glad to see you've had a change of heart ;-) > So replace the weak MSI arch hooks with the #define foo foo idiom. We no > longer need empty versions of arch_setup/teardown_msi_irq(). I'm working on a complete rewrite of the MSI code right now (spurred by the realisation that a device with 2k MSI-X irqs will allocate 150k of MSI-X descriptors, and be a really long list). I'm coming around to the opinion that we should just get rid of the arch_*_irq() interfaces altogether and force architectures to implement arch_*_irqs(). No more weak symbols, no ifdefs, and the interface to the architecture isn't really harder for them to implement. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
