On Monday, January 5, 2009 5:50 am Rafael J. Wysocki wrote: > On Monday 05 January 2009, Ingo Molnar wrote: > > * Rafael J. Wysocki <rjw@xxxxxxx> wrote: > > > From: Rafael J. Wysocki <rjw@xxxxxxx> > > > > > > pcibios_enable_device() and pcibios_disable_device() don't handle > > > IRQs for devices that have MSI enabled and it should tread the > > > > s/tread/treat > > Ah, thanks. > > > > devices with MSI-X enabled in the same way. > > > > > > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx> > > > --- > > > arch/x86/pci/common.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > looks good - Jesse, what do you think? > > > > Rafael, i'm curious is this in response to some regression/bug? Did some > > box or driver get confused by us enabling/disabling the GSI? Some IRQ > > flood perhaps? > > Well, I don't have any MSI-X capable boxes around. :-) > > I was just reviewing the code and spotted this. > > > btw., there's a small observation: > > > + if (!dev->msi_enabled && !dev->msix_enabled) > > > > maybe a "pci_has_gsi_irq()" wrapper would make these checks cleaner and > > would make things more robust, should there be any new IRQ delivery > > method be introduced in the future? > > Well, perhaps something like the patch below? > > Thanks, > Rafael > > --- > Subject: x86 PCI: Do not use interrupt links for devices using MSI-X (rev. > 2) From: Rafael J. Wysocki <rjw@xxxxxxx> > > pcibios_enable_device() and pcibios_disable_device() don't handle > IRQs for devices that have MSI enabled and it should treat the > devices with MSI-X enabled in the same way. > > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx> Looks good, applied this one. Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
