Alan and Jesse, After patching your code, I did some tests with VIA's USB HOST controller. The system can do S3 resume by clicking USB KB/MS. So, should I make a new patch for merging your patches and re-sumbit to the mailing-list? In addition, I cannot find which kernel source Jesse made the patch. So I manually patch the code into 2.6.28-rc8. BRs, Joseph Chan -----Original Message----- From: Alan Stern [mailto:stern@xxxxxxxxxxxxxxxxxxx] Sent: Wednesday, December 17, 2008 6:12 AM To: Joseph Chan; Jesse Barnes Cc: USB list; linux-pci@xxxxxxxxxxxxxxx; Rafael Wysocki Subject: Re: [PATCH] also init can_wakeup if platform supports PCI device wakeup On Tue, 16 Dec 2008, Alan Stern wrote: > I almost forgot -- there still needs to be a call to > device_set_wakeup_enable(). So you would need to insert that instead > of inserting device_init_wakeup(). In fact, probably this patch is what you really need. This combined with Jesse's change should work. Alan Stern Index: usb-2.6/drivers/usb/core/hcd-pci.c =================================================================== --- usb-2.6.orig/drivers/usb/core/hcd-pci.c +++ usb-2.6/drivers/usb/core/hcd-pci.c @@ -128,6 +128,7 @@ int usb_hcd_pci_probe(struct pci_dev *de } pci_set_master(dev); + device_set_wakeup_enable(&dev->dev, 1); retval = usb_add_hcd(hcd, dev->irq, IRQF_DISABLED | IRQF_SHARED); if (retval != 0) ��.n��������+%������w��{.n�����{���"�)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
