On Tue, 16 Dec 2008, Jesse Barnes wrote: > > Why doesn't the PCI core set the can_wakeup flag when a PCI device is > > first discovered? > > pci_pm_init() should do that, from pci_init_capabilities(), but only if the > device has PM caps will can_wakeup be set correctly. OTOH, pci_enable_wake() > will enable wake on a device even w/o PM caps if the platform supports it. We > don't check for platform support at init time though, so if your driver checks > for can_wake it may fail. So something like this patch might be what you're > looking for? Or are you seeing cases where the PM cap bits are ignored too? > In that case we'd have a bug in our pm_init code... Yes, this is what I had in mind. Joseph, does Jesse's patch fix your problem? If it does then we ought to be able to remove the device_init_wakeup() calls in ehci-pci.c and ohci-hcd.c. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
