* Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx>:
> ACPI based hog-pluggable PCIe slot detection logic was added to
^^^
"hot"
> prevent the problem non hot-pluggable PCIe slot was detected as
> hot-pluggable. The slot detection logic can be selected through
> 'pciehp_detect_mode', but it would be better if it is selected
> automatically.
>
> This patch adds 'auto' option for 'pciehp_detect_mode'. When it is
> specified, pciehp judges which 'acpi' or 'pcie' should be used. It
> seems that the physical slot number is duplicated among some slots on
> most of the platforms with the above-mentioned problem. So 'auto' mode
> uses this information to judge which 'acpi' or 'pcie' should be
> used. That is, if duplicated physical slot numbers are detected,
> 'acpi' mode is used. This method is not perfect, but it's realistic.
>
> Signed-off-by: Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx>
>
> ---
> drivers/pci/hotplug/pciehp_acpi.c | 80 ++++++++++++++++++++++++++++++++++++--
> 1 file changed, 76 insertions(+), 4 deletions(-)
>
> Index: 20081212/drivers/pci/hotplug/pciehp_acpi.c
> ===================================================================
> --- 20081212.orig/drivers/pci/hotplug/pciehp_acpi.c
> +++ 20081212/drivers/pci/hotplug/pciehp_acpi.c
> @@ -28,15 +28,18 @@
>
> #define PCIEHP_DETECT_PCIE (0)
> #define PCIEHP_DETECT_ACPI (1)
> -#define PCIEHP_DETECT_DEFAULT PCIEHP_DETECT_PCIE
> +#define PCIEHP_DETECT_AUTO (2)
> +#define PCIEHP_DETECT_DEFAULT PCIEHP_DETECT_AUTO
Ok, I guess I take back what I said in my earlier comment. Maybe
the 'auto' algorithm will break on some machine in the field and
it will be nice to give the user a way to select the detection
mode.
Thanks for making auto the default.
/ac
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
