* Ville Syrjälä <syrjala@xxxxxx>:
> On Thu, Dec 11, 2008 at 11:16:44AM -0700, Alex Chiang wrote:
> > From: Justin Chen <justin.chen@xxxxxx>
> >
> > Certain HP machines require the full 64 bits of _SUN as allowed
> > by the ACPI spec. Without this change, we get name collisions in
> > the lower 32 bits of the _SUN returned by firmware.
> >
> > Signed-off-by: Justin Chen <justin.chen@xxxxxx>
> > Signed-off-by: Alex Chiang <achiang@xxxxxx>
> > ---
> > diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
> > index f9e244d..9bcb6cb 100644
> > --- a/drivers/pci/hotplug/acpiphp.h
> > +++ b/drivers/pci/hotplug/acpiphp.h
> > @@ -113,7 +113,7 @@ struct acpiphp_slot {
> >
> > u8 device; /* pci device# */
> >
> > - u32 sun; /* ACPI _SUN (slot unique number) */
> > + unsigned long long sun; /* ACPI _SUN (slot unique number) */
>
> Why not make it u64 if that's what ACPI says it should be?
Some 64-bit architectures typedef u64 to unsigned long, and some
to unsigned long long.
I'd prefer not to have to cast it to a (ULL) every time I want to
printk.
Thanks.
/ac
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
