Hi! > Hm, this hunk didn't get it? > > @@ -296,6 +357,7 @@ static void sysfs_cleanup_dev(struct pci_dev *d) > close(a->fd); > a->fd = -1; > } > + pci_mfree(d->phy_slot); > } Sorry, it did, but I was searching for that in the generic code (pci_free_dev), which is a more natural place. Could you please move it there? > I was thinking of having sysfs_fill_slots() set the > PCI_FILL_PHYS_SLOT bit in d->known_fields, but that is on a > per-device basis, right? Yes. > Wouldn't that lead to us checking over and over for devices that > do not have slot entries in sysfs? No, because you can set PCI_FILL_PHYS_SLOT after you _try_ to detect the slot, regardless of whether the detection succeeded. > Finally, did this version address the ABI issue? I wasn't sure > about that. Yes, it is correct now. Have a nice fortnight -- Martin `MJ' Mares <mj@xxxxxx> http://mj.ucw.cz/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth P.C.M.C.I.A. stands for `People Can't Memorize Computer Industry Acronyms' -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
