Acked. Nice capture. Yanmin >>-----Original Message----- >>From: Hidetoshi Seto [mailto:seto.hidetoshi@xxxxxxxxxxxxxx] >>Sent: Monday, December 01, 2008 3:31 PM >>To: linux-pci@xxxxxxxxxxxxxxx; Nguyen, Tom L; Zhang, Yanmin >>Cc: linux-kernel@xxxxxxxxxxxxxxx >>Subject: [PATCH] aerdrv: fix sanity check in report_resume >> >>What we have to check here before calling it is err_handler->resume. >>It seems that this block have been copy&pasted from report_slot_reset. >> >>Signed-off-by: Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx> >>--- >> drivers/pci/pcie/aer/aerdrv_core.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >>diff --git a/drivers/pci/pcie/aer/aerdrv_core.c >>b/drivers/pci/pcie/aer/aerdrv_core.c >>index dfc63d0..aac7006 100644 >>--- a/drivers/pci/pcie/aer/aerdrv_core.c >>+++ b/drivers/pci/pcie/aer/aerdrv_core.c >>@@ -252,7 +252,7 @@ static void report_resume(struct pci_dev *dev, void *data) >> >> if (!dev->driver || >> !dev->driver->err_handler || >>- !dev->driver->err_handler->slot_reset) >>+ !dev->driver->err_handler->resume) >> return; >> >> err_handler = dev->driver->err_handler; >>-- >>1.6.0 >> -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html