Re: [PATCH 0/4] Add VPD support to pciutils (2nd try)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Martin Mares wrote:
> Ben,
> 
> > This should answer all your comments.
> 
> I will apply it very soon.
> 
> One more issue to resolve: Should we display the VPD automatically
> whenever the verbose mode is switched on? It probably doesn't clutter
> the output too much, so the obvious answer would be yes, but if we
> extend libpci to read the VPD via config space, which is unsafe,
> it probably should not be done without an explicit request.
> 
> Do you agree with adding an option controlling VPD display?

Any access method that doesn't have a mutex for the VPD should not
be used by default.  I don't think an option should be needed to
use the sysfs method.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux