Re: [PATCH 1/5] Add pci_read_vpd() function and internal read_vpd() method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> --- a/lib/internal.h
> +++ b/lib/internal.h
> @@ -25,6 +25,7 @@ struct pci_methods {
>    void (*scan)(struct pci_access *);
>    int (*fill_info)(struct pci_dev *, int flags);
>    int (*read)(struct pci_dev *, int pos, byte *buf, int len);
> +  int (*read_vpd)(struct pci_dev *, int pos, byte *buf, int len);
>    int (*write)(struct pci_dev *, int pos, byte *buf, int len);
>    void (*init_dev)(struct pci_dev *);
>    void (*cleanup_dev)(struct pci_dev *);

Also, sticking read_vpd inbetween two configuration space access functions
is kinda illogical.

				Have a nice fortnight
-- 
Martin `MJ' Mares                          <mj@xxxxxx>   http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
This line is umop apisdn.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux