On Thu, Nov 13, 2008 at 01:48:59PM -0700, Matthew Wilcox wrote: > Why not: > > status = acpi_get_handle(handle, "_EJ0", &tmp); > if (ACPI_SUCCESS(status)) > return 1; > > status = acpi_get_handle(handle, "_RMV", &tmp); > if (ACPI_SUCCESS(status)) > return 1; > > return 0; Oh, yes, that'd work. > > + if (ACPI_SUCCESS(status) || is_dock_device(handle)) > > + valid = 1; > > + > > + if (!valid) > > return AE_OK; > > This looks like almost the same code as above. New helper function? It's not quite the same, but yes, I'll see if it can be reduced. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
