On Fri, 2008-11-07 at 08:53 +0000, Jan Beulich wrote: > msix_flush_writes() is being called exclusively after calling msi_set_mask_bit(), > and that function already does follow writel() by readl() in the MSI-X case. Which makes me wonder why the initial patch was necessary? http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=988cbb15e00e6f924d052874b40c6a5447f9fdd7 http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/pci/msi.c;h=a4ef93ea4c547b78bf80b5b12c9c20101bd3a1ec;hb=988cbb15e00e6f924d052874b40c6a5447f9fdd7 AFAICS there was already a readl() in msi_set_mask_bit(), so either the initial patch didn't do anything useful or we're missing the point. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
Attachment:
signature.asc
Description: This is a digitally signed message part
