Re: [Pcihpd-discuss] [PATCH] acpiphp: Match the variable types for ia64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chen, Justin wrote:
> The variable "sun" defined in acpiphp_glue.c as "unsigned long".  But the
> struct acpiphp_slot defines the sun as u32 in acpiphp.h.
>
> On the ia64, since the "unsigned long" is u64, the above mismatch may cause
> the problem if the _SUN returns the value in 64 bits.
>
> The following patch change the definition in acpiphp.h to match the type of
> sun with other places.
>
> Singed-off-by: Justin Chen <justin.chen@xxxxxx>
>
> =========================================================================
> --- a/drivers/pci/hotplug/acpiphp.h     2008-01-26 15:31:18.000000000 -0800
> +++ b/drivers/pci/hotplug/acpiphp.h     2008-09-03 16:05:10.610000000 -0700
> @@ -112,7 +112,7 @@ struct acpiphp_slot {
>
>         u8              device;         /* pci device# */
>
> -       u32             sun;            /* ACPI _SUN (slot unique number)
> */ +       unsigned long   sun;            /* ACPI _SUN (slot unique
> number) */ u32             slotno;         /* slot number relative to
> bridge */ u32             flags;          /* see below */
>  };
>

This list is dead, linux-pci@xxxxxxxxxxxxxxx is the place to go. Also you did 
not say against which kernel version your patch is.

Greetings,

Eike

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux