> -----Original Message----- > On Tue, Nov 04, 2008 at 02:50:05PM -0700, Matthew Wilcox wrote: > > On Tue, Nov 04, 2008 at 09:10:06AM -0800, Greg KH wrote: > > > On Tue, Nov 04, 2008 at 12:51:53PM -0000, James Woodcock wrote: > > > > Hi, > > > > > > > > I'm not sure if this is the correct place to send this patch. > > > > It's only a small one that adds Aculab's PCI vendor ID > to pci_ids.h. > > > > > > Why is this device id needed here? > > > > > > If it is only used in one driver, just place the id in > that driver, > > > only place ids that are needed in more than one driver > into this file. > > > > It's the vendor ID, not a device ID. > > Sorry for missing that, but my original statement still > stands, why is this needed? We aren't adding new ids unless > we are needing them across more than one driver. Thanks for the reply. Well, it's a bit complicated. We have some cards that are based on the Intel e1000 (and, these days, e1000e) driver. In the past, a colleague (who has since left) tried to get a patch with our device IDs into the standard kernel drivers - that's pretty much the only change that is needed to support our cards. This patch was rejected. I'm not totally sure why, but I'd assume Intel don't want to be seen to be supporting hardware that they have know nothing about - which would be an understandable position. So I have to support our cards by supplying patches to our customers to enable them to recompile the e1000 driver to work with our cards. There are two reasons I would like the patch applied: 1. The device ID is used in both e1000 and e1000e drivers. 2. The simpler my patch is, the more likely it will be able to be applied to future kernels if the standard e1000 code is modified. Hope that helps James Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) P Please consider the environment and don't print this e-mail unless you really need to -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
