Re: [patch 2/2] pci: uninline pci_ioremap_bar()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Arjan van de Ven wrote:
> Rolf Eike Beer wrote:
> > Arjan van de Ven wrote:
> >> Rolf Eike Beer wrote:
> >>> So it's undefined now on !CONFIG_HAS_IOMEM?
> >>
> >> that's not new; if you don't have ioremap() at all, pci_ioremap_bar()
> >> makes no sense whatsoever.
> >> It's already like that in mainline.
> >
> > Yes, but now you have it in the header and no implementation for that.
> > Before you would get a compiler error, now it's a linker one.
>
> the systems that have this are all no-pci *entirely*. Not even maybe.
> So I don't really see this as an issue that actually can happen; sorry.

Than the ifdef in the source file is pretty useless, isn't it?

Eike

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux