Re: [PATCH] pci: print out DMA mask info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 09, 2008 at 04:05:57PM -0700, Yinghai Lu wrote:
> Grant Grundler wrote:
> > On Thu, Oct 09, 2008 at 02:51:32PM -0700, Yinghai Lu wrote:
> >> On Thu, Oct 9, 2008 at 2:35 PM, Matthew Wilcox <matthew@xxxxxx> wrote:
> >>> Why's that interesting to the sysadmin of the machine?  To the driver
> >>> writer, certainly.  But what's the use of it to the people using the
> >>> machine?
> > ...
> >> make linux kernel act like black box as other os?
> > 
> > I don't understand your reply.
> > If someone thinks linux is a black box, printing this message won't help them.
> > 
> could find out easily why some driver doesn't set dma mask correctly.
> like why 
> 	qlogic qla2xxx only set consistent to 64bit,
> 	emulex lpfc not set consistent to 64bit

I agree making the information available is a good idea. It's just
not going to help anyone 99% of the time and isn't a requirement for
booting the machine.

> > 
> > "To flag use of bounce buffer or other suboptimal behaviors" could be debated.
> > 
> > 
> > Regarding associating the output with other PCI messages, I'd hope the fact
> > that the /sys entry is in the same directory as other sys files would be
> > enough clue to associate those together. e.g.:
> > grundler <2068>cd /sys/bus/pci/devices/0000\:01\:00.0/
> > grundler <2069>ls
> > broken_parity_status  driver@  irq         resource0   subsystem_device
> > bus@                  enable   local_cpus  resource1   subsystem_vendor
> > class                 i2c-0/   modalias    resource3   uevent
> > config                i2c-1/   power/      rom         vendor
> > device                i2c-2/   resource    subsystem@
> > 
> 
> add dma_mask coherent_dma_mask here?

Yes, if there is no other more obvious place.
It's just a suggestion which I happen to think is better than
adding more boot time messages.

thanks,
grant
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux