On Thursday, October 2, 2008 8:25 pm Yu Zhao wrote: > Jesse Barnes wrote: > > This patch fixes a long standing bug in the PCI sysfs code, where if we > > were exposing a shadow copy of the ROM (at 0xc0000-0xc0000+128k) we > > wouldn't properly set the size. Any comments? Another approach would be > > to mess with > > The approach in following patch looks fine. > > > pdev->resource[PCI_ROM_RESOURCE] when we do the shadow fixup, but I > > haven't looked to see if that would have bad implications elsewhere. > > I'm on vacation so I didn't check the source code. IIRC, the error > handling code at the bottom of this function might need change > correspondingly. > > And it looks better if it could be: > attr = kzalloc(sizeof(*attr), GFP_ATOMIC); > if (!attr) > goto err_handling; > pdev->rom_attr = attr; > ... Yeah you're right, I've fixed that up. I'll add your ack and push to my linux-next branch. Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
