On Friday, October 3, 2008 10:22 am Andrew Vasquez wrote:
> The interfaces changes overall look like some good clean...
>
> As, far as the qla2xxx specific changes, if you'd like, let's just
> drop the extra 'printk()' INFO and simply call
> pci_enable_pcie_error_reporting().
>
> > diff --git a/drivers/scsi/qla2xxx/qla_os.c
> > b/drivers/scsi/qla2xxx/qla_os.c index 26afe44..7e79835 100644
> > --- a/drivers/scsi/qla2xxx/qla_os.c
> > +++ b/drivers/scsi/qla2xxx/qla_os.c
> > @@ -1567,9 +1567,8 @@ qla2x00_probe_one(struct pci_dev *pdev, const
> > struct pci_device_id *id)
> > goto probe_out;
> > }
> >
> > - if (pci_find_aer_capability(pdev))
> > - if (pci_enable_pcie_error_reporting(pdev))
> > - goto probe_out;
> > + if (!pci_enable_pcie_error_reporting(pdev))
> > + printk(KERN_INFO "qla2xxx: Enabled error reporting\n");
>
> pci_enable_pcie_error_reporting(pdev);
>
> > host = scsi_host_alloc(sht, sizeof(scsi_qla_host_t));
> > if (host == NULL) {
Works for me. You used to abort the probe if things failed, so I wasn't quite
sure what you'd prefer. I'll just convert to a bare
pci_enable_pcie_error_reporting() then.
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
