On Thursday 02 October 2008 12:46:28 pm Jesse Barnes wrote: > On Monday, September 29, 2008 2:03 pm Vincent Legoll wrote: > > Hello, > > > > Here is a patch to uniformize PCI probing debug messages at > > boot with dev_printk() intead of manual printk() > > > > for example, it goes from the mixed-style: > > > > PCI: 0000:00:1b.0 reg 10 64bit mmio: [f4280000, f4283fff] > > pci 0000:00:1b.0: PME# supported from D0 D3hot D3cold > > > > to uniform: > > > > pci 0000:00:1b.0: reg 10 64bit mmio: [f4280000, f4283fff] > > pci 0000:00:1b.0: PME# supported from D0 D3hot D3cold > > > > If people prefer the UPPERCASE "PCI:" prefix from dev_printk(), > > that would be matter for another patch... > > > > I'm currently running the kernel with that patch applied, and > > diffed bootlog, everything looks OK > > > > Signed-off-by: Vincent Legoll <vincent.legoll@xxxxxxxxx> > > Bjorn, how does this jive with the various other debug harmonization patches > you've been putting together & reviewing? I think it's great. The only nit I would change is to use "[%#llx-%#llx]" as we do in pci_request_region(). Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html