Arjan van de Ven wrote: > On Tue, 30 Sep 2008 23:24:50 -0600 > > Grant Grundler <grundler@xxxxxxxxxxxxxxxx> wrote: > > > And pci_iomap() takes more parameters than most driver writers want > > > or need. Most of the time it's "I want the whole bar"; even if my > > > patch wraps around that, making the API simpler is still worth it > > > imo > > > > You are right about that. > > Would calling the API "pci_iomap_bar()" to keep the naming consistent > > help make it more acceptable? > > I'm fine with pci_iomap_bar()... it meets my goals > Would be nice if I'd be allowed to make it only work on MEM bars not IO > bars (so that drivers don't accidentally end up calling this on an IO > bar and then using readl() etc) IIRC pci_iomap() was documented to work on both at it does "the right thing" automatically. Eike
Attachment:
signature.asc
Description: This is a digitally signed message part.
