Re: [PATCH 3/9] PCI: add interface to set visible size of VPD (rev3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2008-09-25 at 13:22 -0400, Jeff Garzik wrote:
[...]
> What is the initial size?
> 
> It seems like a bad idea to start out assuming the max, and reduce once 
> a knowledgeable driver appears.
> 
> It seems more safe to start out at zero, and let a driver increase it?

VPD is meant to be usable even without a driver - that's why it's a
(somewhat) standard capability and not device-specific.

> That way, by design, you eliminate the possibility (later, if not now) 
> of someone assuming that the full 32k can be read as soon as the 
> interface is available.

I believe that's generally true, though it may be slow.

Maybe we could read as much as we need to find the real length when the
sysfs file is first opened?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux