On Wed, Sep 24, 2008 at 02:16:46PM +0800, Yang, Sheng wrote: > On Wednesday 24 September 2008 14:11:04 Grant Grundler wrote: > > On Tue, Sep 23, 2008 at 10:34:30PM -0600, Matthew Wilcox wrote: > > > > > > + return -ENOTSUPP; > > > > > > > > > > return -ENOTTY; > > > > > > > > I will modify this. But I still don't understand why -ENOTTY... I think > > > > there are some history about it? > > > > > > Yes. ENOTTY means "This operation cannot be performed on this device". > > > > "man errno" says: > > ENOTTY Inappropriate I/O control operation (POSIX.1) > > Thanks, Grant! > > But, it's sufficient here? I think FLR is not a I/O control operation... understood...I'm just pulling up the quasi-official definitions for consideration. I'm not trying to dictate what is "right". grant > > -- > regards > Yang, Sheng > > > > > EOPNOTSUPP is some networking error, I forget the details now. > > > > EOPNOTSUPP Operation not supported on socket (POSIX.1) > > > > (ENOTSUP and EOPNOTSUPP have the same value on > > Linux, but according to POSIX.1 these error values should be distinct.) > > > > > > man page doesn't mention ENOTSUPP. And that might be sufficient > > reason to not use it. > > Folks have replaced ENOTSUPP for that reason in the past: > > http://www.uwsg.iu.edu/hypermail/linux/kernel/0402.3/0180.html > > http://linux.derkeiler.com/Mailing-Lists/Kernel/2006-04/msg06283.html > > > > > > hth, > > grant > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html