* Rolf Eike Beer <eike-kernel@xxxxxxxxx>:
> > +
> > + /*
> > + * We hit this the first time through, which gives us
> > + * space for terminating NULL, and then every power of 10
> > + * afterwards, which gives us space to add another digit
> > + * to "name-XX..."
> > + */
> > + if (dup % width == 0) {
> > + len++;
> > + width *= 10;
> > + }
> > +
> > + new_name = krealloc(new_name, len, GFP_KERNEL);
> > + if (!new_name)
> > + goto out;
>
> If krealloc() fails you will leak the old new_name here.
Thanks for catching this. I already responded to Willy that I'm
changing it to:
kfree(new_name);
new_name = kmalloc(len, GFP_KERNEL);
That will prevent any leaks.
Thanks for the review.
/ac
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
