Re: [PATCH v2 01/13] PCI Hotplug core: add 'name' param pci_hp_register interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Matthew Wilcox <matthew@xxxxxx>:
> On Tue, Sep 09, 2008 at 04:00:07AM -0600, Alex Chiang wrote:
> > -extern int pci_hp_register(struct hotplug_slot *, struct pci_bus *, int nr);
> > +extern int pci_hp_register(struct hotplug_slot *,
> > +			   struct pci_bus *,
> > +			   int nr,
> > +			   const char *name);
> 
> Not a huge fan of this style ... the usual style would be:
> 
> extern int pci_hp_register(struct hotplug_slot *, struct pci_bus *, int nr,
> 				const char *name);

Ok, will fix.

> Otherwise Acked-by: Matthew Wilcox <willy@xxxxxxxxxxxxxxx>

Thanks.

/ac

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux