Hi Bjorn,
>> +#define ctrl_dbg(ctrl, format, arg...) \
>> + do { \
>> + if (shpchp_debug) \
>> + dev_printk(, &ctrl->pci_dev->dev, \
>> + format, ## arg); \
>> + } while (0)
>
> Does the above compile? It looks like it's missing the KERN_DEBUG
> or similar argument to dev_printk().
Yes, the above code can be compiled.
> My personal opinion is that all the __func__ stuff is ugly and should be
> removed. But if you're only comfortable doing a minimal dev_printk
> conversion, I understand that. And maybe it'd be best to do it in
> incremental patches:
> - minimal dev_printk conversion (like this one)
> - remove __func__
> - more structural stuff like figuring out PCI domains (see below)
>
It's just as you say, I focused on only a replacement at this stage,
so I left message-bodies alone. I'll refine messages later.
Best regards,
Taku Izumi <izumi.taku@xxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
