[PATCH] pci: make list affinity visible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Looks like Mike created cpulistaffinty in sysfs but never completed the job.
Sparse warned about cpulistaffinity attribute not being static, and then
when I made it static, it was totally unused. This led to the observation
that the associated sysfs file was not being created.  Assuming you want
the sysfs file to exist, this is what is needed.

Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxxxx>

--- a/drivers/pci/probe.c	2008-09-05 08:31:14.000000000 -0700
+++ b/drivers/pci/probe.c	2008-09-05 08:37:35.000000000 -0700
@@ -145,7 +145,7 @@ static ssize_t inline pci_bus_show_cpuli
 }
 
 DEVICE_ATTR(cpuaffinity,     S_IRUGO, pci_bus_show_cpumaskaffinity, NULL);
-DEVICE_ATTR(cpulistaffinity, S_IRUGO, pci_bus_show_cpulistaffinity, NULL);
+static DEVICE_ATTR(cpulistaffinity, S_IRUGO, pci_bus_show_cpulistaffinity, NULL);
 
 /*
  * PCI Bus Class
@@ -1180,6 +1180,9 @@ struct pci_bus * pci_create_bus(struct d
 	error = device_create_file(&b->dev, &dev_attr_cpuaffinity);
 	if (error)
 		goto dev_create_file_err;
+	error = device_create_file(&b->dev, &dev_attr_cpulistaffinity);
+	if (error)
+		goto dev_create_file_err;
 
 	/* Create legacy_io and legacy_mem files for this bus */
 	pci_create_legacy_files(b);
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux