On Friday 22 August 2008 12:46:59 pm Johann Felix Soden wrote: > From: Johann Felix Soden <johfel@xxxxxxxxxxxxxxxxxxxxx> > > Fix printk format warnings: > drivers/pci/probe.c: In function 'pci_read_bridge_bases': > drivers/pci/probe.c:386: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'resource_size_t' > drivers/pci/probe.c:386: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t' > drivers/pci/probe.c:398: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'resource_size_t' > drivers/pci/probe.c:398: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t' > drivers/pci/probe.c:434: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t' > drivers/pci/probe.c:434: warning: format '%llx' expects type 'long long unsigned int', but argument 5 has type 'resource_size_t' > > Signed-off-by: Johann Felix Soden <johfel@xxxxxxxxxxxxxxxxxxxxx> > --- > drivers/pci/probe.c | 11 ++++++++--- > 1 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index cce2f4c..0ad9367 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -383,7 +383,9 @@ void __devinit pci_read_bridge_bases(struct pci_bus *child) > res->start = base; > if (!res->end) > res->end = limit + 0xfff; > - printk(KERN_INFO "PCI: bridge %s io port: [%llx, %llx]\n", pci_name(dev), res->start, res->end); > + printk(KERN_INFO "PCI: bridge %s io port: [%llx, %llx]\n", > + pci_name(dev), (unsigned long long) res->start, > + (unsigned long long) res->end); Thanks for fixing the warnings. I wish you'd changed these at the same time to use dev_info() and "[%#llx-%#llx]" like the rest of PCI. I confess I don't understand where the ioport, mmio, and prefetchable mmio resources are coming from here, but before your patch, these printed values that look like junk on an HP nw8000: PCI: bridge 0000:00:01.0 io port: [2fff00002000, ef92eae800000300] PCI: bridge 0000:00:01.0 32bit mmio: [904fffff90400000, ef92eae800000300] PCI: bridge 0000:00:01.0 32bit mmio pref: [9fffffff98000000, ef92eae8] I just returned the laptop, or I'd double-check to see whether your casts fixed this. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
