On Thursday, July 10, 2008 2:29 pm Milton Miller wrote: > The driver flag dynids.use_driver_data is almost consistently not set, and > causes more problems than it solves. The only use of this flag is to > prevent the system administrator from telling a pci driver additional data > when adding a dynamic match table entry via sysfs. > > We do not as a policy protect the kernel from bad acts by root. > > If we are worried about drivers doing the wrong thing due the match data, > we should be setting a taint flag, not attempting to cut off the admin. > > [1] Searching the next-20080709 tree shows the bit is set by exactly 3 pci > drivers. However, the use of per-match-entry driver data is much more > prevalent: A boot of allyesconfig on a powerpc64 pseries with a debug patch > shows 27 drivers apparently use the field for a pointer, 14 use it for > setting flags, and 98 use it as a table index. (Pointers are defined as > > >PAGE_OFFSET, aka in the 64 bit kernel linear mapping. Flags are defined > > as > > the maximum value exceeds the number of entries in the match table. Any > other nonzero value is classified as an index). > > > Signed-off-by: Milton Miller <miltonm@xxxxxxx> Thanks Milton, I just pushed this into my linux-next branch (though I changed the commit message to reflect further comments in this thread). Jesse -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
