On Wed, Aug 06, 2008 at 07:19:01AM -0600, Matthew Wilcox wrote: > On Wed, Aug 06, 2008 at 10:57:21AM +1000, Simon Horman wrote: > > Check the return value of device_create_bin_file in pci_create_bus and > > unwind if necessary. Don't propagate error to caller, as failure to create > > these files shouldn't prevent PCI from being initialised. > > Much better ... one nit though: > > > static void pci_create_legacy_files(struct pci_bus *b) > > { > [...] > > + > > + return 0; > > I'm sure the compiler warns about that. Amusingly, yes. -- Horms -> looks for somewhere to hide -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html