On Thu, 2008-07-31 at 11:27 +0900, Hidetoshi Seto wrote: > Michael Ellerman wrote: > > But the rest of the patch is nice and I'm not really fussed about the > > naming. And just to be clear you haven't changed the logic of > > free_msi_entries() at all, just moved it to avoid the forward > > declaration - right? > > You are right. Nothing changed in the logic, but just the location. Cool, it's hard to be 100% sure checking just by eye. > It would be reasonable that we place msi_free_irqs() nearby > msi-specific fuctions and msix_free_all_irqs() nearby msix-specific > functions, if they are actually such specific. > But in fact both are same, one common function. Then it is better > location where the forward declaration is. Yep I agree. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
Attachment:
signature.asc
Description: This is a digitally signed message part
