Re: [patch 1/3] disable aspm per acpi FADT table's setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Shaohua,
    I am unclear on how to identify the device involved with the
hang. Without your patches and with the recent PCI debug patches
I see...

PCI: 0000:00:1d.7 reg 10 32bit mmio: [d840500, d84057ff]
pci: 0000:00:1d.7 PME# supported from D0 D3hot D3cold
pci: 0000:00:1d.7 PME# disabled
pci: 0000:00:1f.0 quirk: region 0400-047f claimed by ICH6 ACPI/GPIO/TCO
pci: 0000:00:1f.0 quirk: region 0500-053f claimed by ICH6 GPIO
PCI: 0000:00:1f.1 reg 10 io port: [40d8,40df]
PCI: 0000:00:1f.1 reg 14 io port: [40ec,40ef]
PCI: 0000:00:1f.1 reg 18 io port: [40d0,40d7]
PCI: 0000:00:1f.1 reg 1c io port: [40e8,40eb]
PCI: 0000:00:1f.1 reg 20 io port: [40b0,40bf]
PCI: 0000:00:1f.2 reg 10 io port: [40c8,40cf]
PCI: 0000:00:1f.2 reg 14 io port: [40e4,40e7]
PCI: 0000:00:1f.2 reg 18 io port: [40c0,40c7]
PCI: 0000:00:1f.2 reg 1c io port: [40e0,40e3]
PCI: 0000:00:1f.2 reg 20 io port: [40a0,40af]
PCI: 0000:00:1f.2 reg 24 32bit mmio: [d8405000,d84053ff]
pci: 0000:00:1f.2 PME# supported from D3hot
pci: 0000:00:1f.2 PME# disabled
PCI: 0000:00:1f.3 reg 20 io port [efa0,efbf]
PCI: 0000:01:00.0 reg 10 32bit mmio: [c0000000,cfffffff]
PCI: 0000:01:00.0 reg 14 io port: [3000,30ff]
PCI: 0000:01:00.0 reg 18 32bit mmio: [d8300000,d830ffff]
pci: 0000:01:00.0 : supports D1
pci: 0000:01:00.0 : supports D2 

just before the hang. Since the new patches explicitly list
all of the pre1.1 PCIe devices being disabled for ASPM, I
was hoping I would use the force option coupled with a
disable_pciedevice option to disable them one at a time
until I hit the offending device.
    I have one other question. Is the disabling of pre1.1
PCIe devices a temporary hack? That is will you likely be
able to work around the compatibility issues with pre1.1
devices in aspm in the future to allow the older hardware to
be used or is that impossible to achieve?
             Jack

On Wed, Jul 23, 2008 at 04:35:40PM +0800, Shaohua Li wrote:
> On Wed, 2008-07-23 at 00:32 -0400, Jack Howarth wrote:
> > Shaohua,
> >      Your latest 3 patches applied to 2.6.26-git9 boots fine on my
> > MacBook Pro and produces the dmesg output appended below. 
> Thanks for testing.
> 
> > I do have
> > one suggestion though. Your current patches allow for a blanket force
> > of pcie-aspm usage on pre1.1-PCIe devices. I am wondering if it might
> > be possible to fine-tune that to exempt a particular subset of PCIe
> > ids from the force. Specifically, what if only one pre1.1-PCIe device
> > is breaking the boot. Might it not be possible to force all but that
> > particular PCIe device to be loaded for aspm?
> ok, I can add this later. Did you identify which device is broken in the
> system?
> 
> Thanks,
> Shaohua
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux