On Thu, Jul 10, 2008 at 04:29:37PM -0500, Milton Miller wrote: > The driver flag dynids.use_driver_data is almost consistently not set, and > causes more problems than it solves. The only use of this flag is to > prevent the system administrator from telling a pci driver additional data > when adding a dynamic match table entry via sysfs. > > We do not as a policy protect the kernel from bad acts by root. But we can try. As you found out, this flag should have been set in that specific driver, right? Why not just fix the driver instead of declaring that the flag is not useful at all, despite it actually being used properly by a number of drivers already? So no, this patch is not good, it should stay as-is. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
