On Fri, 2008-07-11 at 17:28 +0900, Hidetoshi Seto wrote: > Hi, > > First of all, it seems that mask/unmask of MSI has problems. > - Per-vector masking is optional for MSI, so I think that allocating > multiple messages for a function without masking capability would be > not good idea, since all vector in the block will be masked/unmasked > at once without any agreement. > - Even if the function supports per-vector masking, current > mask/unmask_msi_irq() functions assume that MSI uses only one vector, > therefore they only set/unset the first bit of the maskbits which > for the first vector of the block. The bits for other vectors are > initialized as 'masked' but no one unmask them. I tend to think we should just do soft-masking anyway for MSI... better than whacking config space. Ben -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
