On Thu, 2008-07-03 at 08:12 -0700, Jesse Barnes wrote: > On Thursday, July 03, 2008 1:47 am Zhao Yakui wrote: > > Subject:PCI: Disable PME function of PCI device when scanning PCI device > > > > >From : Zhao Yakui <yakui.zhao@xxxxxxxxx> > > > > Maybe #PME is enabled for some PCI devices.And if the PME event can > > be generated from D0 state, PME event will be generated when the PCI > > device is in D0 state. If the device driver is not loaded for this PCI > > device(PME can't be disabled) and the correspond GPE is enabled, the > > system will be resumed immediately from the suspend state. This's not > > what we wanted. > > Thre is a similar case in ACPI system. If the ACPI device has the > > _PRW object, the _PSW/_DSW object will be called in order to disable the > > wakeup functionality. Only when it is allowed to wake up the sleeping > > state, OSPM will enable it again. > > > > So it will be reasonable that PME is disabled in the course of > > scanning PCI device and enabled again only when PME event is required to > > be generated from the requested PCI state.(For example: D3_hot, > > D3_cold). Of course it is also safe to disable PME again when the PME is > > disabled for the PCI devices. > > I've already got this queued in linux-next... Are you seeing spurious wakeups > on some platforms? I haven't seen any reports yet, so I didn't think it was > necessary to push this into 2.6.26... Thanks for queuing this patch in linux-next tree. I haven't seen such spurious wakeup nor any reports about it. But IMO it is safe to do so and harmless. Thanks. > Thanks, > Jesse -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
