Re: [PATCH] PCI: Restrict VPD read permission to root

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Benjamin Li wrote:
> Hi Jesse, Matt, and Ben,
> 
> The following is a patch which is needed to prevent Broadcom 5706, 5708 and
> 5709 rev A. nics from hanging with the current PCI VPD code.  Switching the
> permissions to be read by root still does not solve the case when any app
> with root privileges tries to read the VPD data from these nics.  It will
> still hang the device.

We should certainly do something like this for later kernel versions.  But
I think it's acceptable to let root break the system.  This same problem
exists with parts of config space on some devices, which is why only the
first 64 bytes are world-readable.  

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux