Re: [PATCH 4/7] pciehp: fix typo in hpc_release_ctlr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bjorn Helgaas wrote:
> On Tuesday 24 June 2008 09:04:47 pm Kenji Kaneshige wrote:
>> Bjorn Helgaas wrote:
>>> On Thursday 19 June 2008 09:06:24 pm Kenji Kaneshige wrote:
>>>> Fix the typo in hpc_release_ctlr().
>>>>
>>>> Signed-off-by: Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx>
>>>>
>>>> ---
>>>>  drivers/pci/hotplug/pciehp_hpc.c |    2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> Index: 20080617/drivers/pci/hotplug/pciehp_hpc.c
>>>> ===================================================================
>>>> --- 20080617.orig/drivers/pci/hotplug/pciehp_hpc.c
>>>> +++ 20080617/drivers/pci/hotplug/pciehp_hpc.c
>>>> @@ -613,7 +613,7 @@ static void hpc_release_ctlr(struct cont
>>>>  {
>>>>  	/* Mask Hot-plug Interrupt Enable */
>>>>  	if (pcie_write_cmd(ctrl, 0, HP_INTR_ENABLE | CMD_CMPL_INTR_ENABLE))
>>>> -		err("%s: Cannot mask hotplut interrupt enable\n", __func__);
>>>> +		err("%s: Cannot mask hotplug interrupt enable\n", __func__);
>>> Can you use dev_err() to associate the message with a device or
>>> root port or something?
>> Thank you very much for comment.
>> There are many other messages that also need to be changed in pciehp
>> driver. So I'll do that as another patch.
> 
> That'd be tremendous (IMHO).  I posted patches to do that for some
> of PCI, but I haven't done anything under drivers/pci/hotplug, because
> it seemed like it'd be nice to do all the hotplug drivers at once.  And
> there are a lot.
> 

Maybe it's difficult for me to do all the hotplug driver at once, because
I don't know about some of hotplug controllers at all and I don't have
test environment for those. So I want to try to do for pciehp as a first
step.

Thanks,
Kenji Kaneshige


--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux