Jesse Barnes wrote: > On Thursday, June 19, 2008 8:01 pm Kenji Kaneshige wrote: >> Hi, >> >> Here are some cleanup/fix patches for pciehp driver. Some of >> these patches are based on the feedbacks from ML I got when >> I posted other patches before. Patches are: >> >> - [PATCH 1/7] pciehp: cleanup pcie_poll_cmd >> - [PATCH 2/7] pciehp: change command polling frequency >> - [PATCH 3/7] pciehp: remove inline from command related functions >> - [PATCH 4/7] pciehp: fix typo in hpc_release_ctlr >> - [PATCH 5/7] pciehp: fix interrupt initialization >> - [PATCH 6/7] pciehp: use get_service_data >> - [PATCH 7/7] pciehp: remove needless command completed interrupt setting > > Kenji-san, thanks as usual for your good work. :) > > 1-4 look great (and I'm looking forward to the other msg cleanups too), I'll > apply them to linux-next now. > > 5 looks good too, but it's a significant change so I'd like to get at least > one more pair of eyes on it (I also want to look at it again in more detail). > Any volunteers? > > 6 & 7 are also fine, but I'd like the changelogs to give a little more detail > (mainly answering "why is set_service_data preferable?" and "why don't we > need to set command completed?"). > > So can you repost the last two? Sure. I'll send updated pathces. Thank you for reviewing. Thanks, Kenji Kaneshige -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
