RE: [PATCH] igb: completely disable interrupts during netpoll

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andy Gospodarek wrote:
> Globally disable the interrupt during netpoll rather than simply
> disabling it on the hardware.  This will ensure all pending operations
> are complete and no more will execute.  I've seen reports of deadlocks
> with the current driver and this patch resolves them.

I agree this patch is probably okay, and if it fixes a specific problem
should be accepted however I have a question that didn't apply when we
originally created code like this.

> @@ -4024,7 +4024,7 @@ static void igb_netpoll(struct net_device
>  	*netdev) int i;
>  	int work_done = 0;
> 
> -	igb_irq_disable(adapter);
> +	disable_irq(adapter->pdev->irq);

how does changing to disable_irq/enable_irq work with MSI and MSI-X
interrupts?
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux