On Thu, 05 Jun 2008 15:05:59 +0900 Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx> wrote: > Andrew Morton wrote: > > On Wed, 4 Jun 2008 14:16:06 -0600 Alex Chiang <achiang@xxxxxx> wrote: > > > >> From: Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx> > >> > >> Export kobject_rename() to fix the following link error. This happens when > >> pci_hotplug_core driver is compiled as a kernel module. > >> > >> ERROR: "kobject_rename" [drivers/pci/hotplug/pci_hotplug.ko] undefined! > >> make[1]: *** [__modpost] Error 1 > >> make: *** [modules] Error 2 > >> make: *** Waiting for unfinished jobs.... > >> > >> Signed-off-by: Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx> > >> Acked-by: Alex Chiang <achiang@xxxxxx> > >> Cc: Greg KH <greg@xxxxxxxxx> > >> Cc: Kristen Carlson Accardi <kristen.c.accardi@xxxxxxxxx> > >> Cc: Len Brown <lenb@xxxxxxxxxx> > >> Signed-off-by: Alex Chiang <achiang@xxxxxx> > >> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > >> --- > >> lib/kobject.c | 1 + > >> 1 files changed, 1 insertions(+), 0 deletions(-) > >> > >> diff --git a/lib/kobject.c b/lib/kobject.c > >> index 718e510..dcade05 100644 > >> --- a/lib/kobject.c > >> +++ b/lib/kobject.c > >> @@ -439,6 +439,7 @@ out: > >> > >> return error; > >> } > >> +EXPORT_SYMBOL_GPL(kobject_rename); > > > > Shouldn't this go straight into 2.6.26? > > > > > > I think "No", because currently its only required by Alex's "pci slot" > patches. In that case the fix should be integrated into the patch which it is fixing. Well, it doesn't _have_ to be integrated because in this case it can precede acpi-pci-slot-detection-driver.patch. But we might as well fold it, to keep the commit noise level down. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
